Corgul’s Enchanted Sash should be able to be altered

Discussion in 'Bug Reports' started by meta, May 17, 2021.

  1. meta

    meta New Member



    Messages:
    5
    Achievement Pts:
    1
    Hi,

    Zara already made a truly amazing report on the alteration and the details of the items that can be altered, so I'll link it here for reference:
    https://uoalive.com/forum/index.php?threads/scholars-halo-should-be-wearable-by-gargoyles.623/

    Corgul's Sash should also be wearable by Gargoyles. Some proof and documentation I've found:

    Proposed Solution:
    Looking at the Lieutenant Of The Britannian Royal Guard code, it seems they do not use the Exalted Artificer, but instead the "Alter Item" option in Tailoring menu.

    Because of that, I think the first 3 lines of CorgulsEnchantedSash.cs (ServUO/CorgulsEnchantedSash.cs at 05cdc8780ecd81a6abca0f5f14097c8e6bc4860f · ServUO/ServUO · GitHub) would become:

    Code:
    using Server.Engines.Craft;
    
    namespace Server.Items
    {
        [Alterable(typeof(DefTailoring), typeof(GargishCorgulsEnchantedSash))]
        public class CorgulsEnchantedSash : BodySash
    Also, adding the gargish definition before closing the namespace {}'s (second to last line):

    Code:
    public class GargishCorgulsEnchantedSash : GargishSash
        {
            public override int LabelNumber => 1149781;
    
            [Constructable]
            public GargishCorgulsEnchantedSash()
            {
                Attributes.BonusStam = 1;
                Attributes.DefendChance = 5;
            }
    
            public GargishCorgulsEnchantedSash(Serial serial)
                : base(serial)
            {
            }
    
            public override void Serialize(GenericWriter writer)
            {
                base.Serialize(writer);
                writer.Write(0);
            }
    
            public override void Deserialize(GenericReader reader)
            {
                base.Deserialize(reader);
                int version = reader.ReadInt();
            }
        }
     
    #1 meta,
  2. meta

    meta New Member



    Messages:
    5
    Achievement Pts:
    1
    Hi! If you need any more information about this issue or any more help to fix it let me know
     
    #2 meta,
  3. tr1age

    tr1age Administrator Staff Member



    Messages:
    696
    Achievement Pts:
    28
    Have you tested this out perchance?
     
  4. meta

    meta New Member



    Messages:
    5
    Achievement Pts:
    1
    Hi!

    I downloaded current ServUO master branch and tested it. Please find more information below.

    Current behaviour on ServUO Master "as is" (which is the same as UOAlive):

    upload_2021-6-9_15-7-16.png

    Expected behaviour after proposed solution:
    upload_2021-6-9_15-7-34.png


    Also, please find the full code for the item below:
     
    #4 meta,
  5. tr1age

    tr1age Administrator Staff Member



    Messages:
    696
    Achievement Pts:
    28
    Excellent, live with next patch. Thank you :)
     
    • Love Love x 1

Share This Page